Delete/Trash confirmation dialogue: Fix misleading title and make consistent

Authored by marten on Mar 17 2019, 8:47 PM.



The misleading title that brought this dialogue to my attention is where there is only one selected item to move to the trash. In this case the question wording is correct but the message box title says "Delete Permanently?". This is the code for "case Trash" and "if (prettyList.count() == 1)" in KIO::JobUiDelegate::askDeleteConfirmation().

This should be corrected to say "Move to Trash" as in the other conditional below.

There are some other anomalies which are also corrected in this diff:

a) The "Delete Permanently" message box title has a question mark, but "Move to Trash" does not. I can't find a HIG rule for which of those is correct, but for consistency and in accordance with "Do not use the title to explain what to do in the dialog – that’s the purpose of the main instruction" the question marks are removed.

b) Capitalisation of "Trash" made consistent in the question for trash of multiple items.

Test Plan

Built KIO with these changes, checked all combinations of delete/trash operations in Dolphin and verified that the correct message box title and question is shown.

Diff Detail

R241 KIO
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.Mar 17 2019, 8:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 17 2019, 8:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
marten requested review of this revision.Mar 17 2019, 8:47 PM
ngraham accepted this revision.Mar 17 2019, 11:45 PM
ngraham added a reviewer: VDG.
ngraham added a subscriber: ngraham.

Nice catch!

This revision is now accepted and ready to land.Mar 17 2019, 11:45 PM
This revision was automatically updated to reflect the committed changes.