When the previewed video stops playing (because of the user or because the media playback has ended), show the regular preview only if the preview setting is on.
ClosedPublic

Authored by meven on Mar 17 2019, 7:37 PM.

Details

Summary

Bug result after test plan :

Test Plan

In dolphin with the information panel
Select a video
Play the video
Disable the preview through the context menu (the video stays playing and visible and this will get fixed in a subsequent review)
Stop the video -> the video preview reappears when it should not

Diff Detail

Repository
R318 Dolphin
Branch
bug-fix-preview
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9752
Build 9770: arc lint + arc unit
meven created this revision.Mar 17 2019, 7:37 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 17 2019, 7:37 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Mar 17 2019, 7:37 PM
meven edited the summary of this revision. (Show Details)Mar 17 2019, 7:44 PM
meven edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mar 17 2019, 8:03 PM
meven added a comment.Mar 17 2019, 8:10 PM

Thanks

Should it go to master or Application/19.04 ?

Thanks

Should it go to master or Application/19.04 ?

Applications/19.04, because bugfixes always go to the stable branch by definition.

Note that until the feature freeze on March 21, every commit should go to Applications/19.04, unless it's something we don't want to ship in the upcoming release (e.g. a new feature which could break things).

This revision was automatically updated to reflect the committed changes.