[powerdevil] Touch up messages/prompts
ClosedPublic

Authored by rooty on Mar 17 2019, 5:54 PM.

Diff Detail

Repository
R122 Powerdevil
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9750
Build 9768: arc lint + arc unit
rooty created this revision.Mar 17 2019, 5:54 PM
Restricted Application added a project: Plasma. Β· View Herald TranscriptMar 17 2019, 5:54 PM
Restricted Application added a subscriber: plasma-devel. Β· View Herald Transcript
rooty requested review of this revision.Mar 17 2019, 5:54 PM
rooty updated this revision to Diff 54118.Mar 17 2019, 5:56 PM

Remove "as soon as possible" (less anxiety-inducing)

rooty added a comment.Mar 17 2019, 6:00 PM

I'm not sold on the use of pronouns here, we could actually do without them
If we agree to keep the pronouns, I'm not going to object but... we can sound both non-technical and professional at the same time :D

P.S. I could use input on "All planned sleep", it's less technical but it's plain weird :D

rooty updated this revision to Diff 54121.Mar 17 2019, 6:02 PM

Fix "be go"

rooty updated this revision to Diff 54123.Mar 17 2019, 6:05 PM

Make sleep prompt more natural-sounding

Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours?

Don't have a better idea for planned sleep, maybe just planned sleep actions?

rooty added a comment.Mar 17 2019, 6:08 PM

Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours?

Haha yeah.
Granted, even these pronouns are waaaay better than the prompt saying "I am going to sleep."
Outright creepy :D

rooty updated this revision to Diff 54129.Mar 17 2019, 6:38 PM

Add the verb run (because... why not)

rooty updated this revision to Diff 54132.Mar 17 2019, 6:55 PM

Touch up some more

rooty updated this revision to Diff 54135.Mar 17 2019, 7:05 PM

Drop unnecessary pronouns

rooty updated this revision to Diff 54137.EditedMar 17 2019, 7:18 PM

Bring back the possessive pronouns

ngraham requested changes to this revision.Mar 17 2019, 9:19 PM

Mostly good, just a new nitpicks and suggestions:

daemon/powerdevilcore.cpp
256

I'd say "using activity <whatever>"

330

Remove "the profile"

367

"or the action is not supported" -> "or the action not being supported"

541

Are we 100% sure that name will always be a good enough string that the user will recognize it as their mouse? (not a rhetorical question, I really am wondering :) )

Same for other instances below too.

607

"go into" -> "enter" ?

612

"go to sleep" is just fine here

643

Not sure this comment is really necessary :)

This revision now requires changes to proceed.Mar 17 2019, 9:19 PM
rooty marked 7 inline comments as done.Mar 18 2019, 5:36 AM
rooty added inline comments.
daemon/powerdevilcore.cpp
330

Hmm sure

367

"or because the action is not supported", "This is due to the action not being supported" sounds too elaborate for my taste and I'd rather have a disconnected clause here

541

I thought about that, then realized that the heading says "Mouse" (Mouse Battery Low) "Keyboard" etc. so it seems redundant too (to repeat it in the body text)

607

Better, yes. We could use just "enter hibernation" without mode too

612

Not very fancy tho 🀣

643

:)

rooty updated this revision to Diff 54165.Mar 18 2019, 5:40 AM
rooty marked 9 inline comments as done.

Implement inline comment suggestions

rooty updated this revision to Diff 54166.Mar 18 2019, 5:43 AM

Missed one

rooty updated this revision to Diff 54167.Mar 18 2019, 5:44 AM

Remove unnecessary comment

rooty updated this revision to Diff 54168.Mar 18 2019, 5:46 AM

Activity...

ngraham accepted this revision.Mar 18 2019, 8:59 AM

Awesome. Go ahead and make your proposed change if you'd like, then shipit!

daemon/powerdevilcore.cpp
367

That was actually going to be my first suggestion. :) Go ahead and do that if you think it sounds better.

541

Ah, you're right!

This revision is now accepted and ready to land.Mar 18 2019, 8:59 AM
rooty updated this revision to Diff 54260.Mar 18 2019, 8:14 PM

"or because"

rooty added inline comments.Mar 18 2019, 8:14 PM
daemon/powerdevilcore.cpp
330

Actually you're right, without "the profile" and "it" it sounds fancier haha

This revision was automatically updated to reflect the committed changes.
broulik added inline comments.Mar 21 2019, 10:18 PM
daemon/powerdevilcore.cpp
541–542

Since you removed the separation between the three cases you might as well unify the codebase into one. Now you have three separate identical strings.

Also, "The battery in (some device) is running low" with the parenthesis is a bit awkward since now it's the sentence's subject.

580

not a fan of that hyphen. It is in the heading, so just change the main text to "To continue using your computer..."

641

Sounds like from now on it will never suspend anymore.