Differential D19836

Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team Drive.
ClosedPublic
Actions

Authored by barchiesi on Mar 17 2019, 5:11 PM.

Tags

Subscribers

kde-pim, LibKGAPI

Details

Reviewers

Maniphest Tasks

T10521: [Drive] Implement Team Drives portion of the API

Commits

R477:b9fbf330daca: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team…
R477:7eff624deb18: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team…

Summary

Add TeamdriveModifyJob and add missing setters to Teamdrive.

Test Plan

Add TeamdriveModifyJobTest for Team Drive renaming test and update team drive example allowing to rename selected Team Drives.

Diff Detail

Repository

R477 KGAPI Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

barchiesi created this revision.Mar 17 2019, 5:11 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 17 2019, 5:11 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

barchiesi requested review of this revision.Mar 17 2019, 5:11 PM

barchiesi added a task: T10521: [Drive] Implement Team Drives portion of the API.

Had some typos in copyright notices.

autotests/drive/teamdrivecreatejobtest.cpp
1–20	This explains everything

dvratil requested changes to this revision.Mar 17 2019, 5:43 PM

dvratil added inline comments.

autotests/drive/teamdrivecreatejobtest.cpp
2	Oh. I love this! :D
autotests/drive/teamdrivedeletejobtest.cpp
2	I love this one even more! :D
src/drive/teamdrivemodifyjob.cpp
108	You should `return` here after calling `emitFinished()`: processing another item after emitting result can lead to some weird states and behavior.

This revision now requires changes to proceed.Mar 17 2019, 5:43 PM

barchiesi updated this revision to Diff 54115.Mar 17 2019, 5:53 PM

dvratil accepted this revision.Mar 17 2019, 5:57 PM

This revision is now accepted and ready to land.Mar 17 2019, 5:57 PM

Closed by commit R477:7eff624deb18: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team… (authored by barchiesi, committed by dvratil). · Explain WhyMar 17 2019, 6:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/CMakeLists.txt (1 line)
A	M		autotests/drive/data/teamdrive_modify_request.txt (7 lines)
A	M		autotests/drive/data/teamdrive_modify_response.txt (8 lines)
P			autotests/drive/teamdrivecreatejobtest.cpp (4 lines) Copied to autotests/drive/teamdrivemodifyjobtest.cpp
M			autotests/drive/teamdrivedeletejobtest.cpp (4 lines)
P			autotests/drive/teamdrivemodifyjobtest.cpp (37 lines) Copied from autotests/drive/teamdrivecreatejobtest.cpp
M			examples/teamdrive/mainwindow.h (10 lines)
M			examples/teamdrive/mainwindow.cpp (44 lines)
M			examples/teamdrive/ui/main.ui (30 lines)
M			src/drive/CMakeLists.txt (2 lines)
M			src/drive/teamdrive.h (99 lines)
M			src/drive/teamdrive.cpp (65 lines)
P			src/drive/teamdrivecreatejob.h (2 lines) Copied to src/drive/teamdrivemodifyjob.h
P			src/drive/teamdrivemodifyjob.h (30 lines) Copied from src/drive/teamdrivecreatejob.h
A	M		src/drive/teamdrivemodifyjob.cpp (117 lines)

Diff 54122

autotests/CMakeLists.txt

Loading...

autotests/drive/data/teamdrive_modify_request.txt

Loading...

autotests/drive/data/teamdrive_modify_response.txt

Loading...

autotests/drive/teamdrivecreatejobtest.cpp

Loading...

autotests/drive/teamdrivedeletejobtest.cpp

Loading...

autotests/drive/teamdrivemodifyjobtest.cpp

Loading...

examples/teamdrive/mainwindow.h

Loading...

examples/teamdrive/mainwindow.cpp

Loading...

examples/teamdrive/ui/main.ui

Loading...

src/drive/CMakeLists.txt

Loading...

src/drive/teamdrive.h

Loading...

src/drive/teamdrive.cpp

Loading...

src/drive/teamdrivecreatejob.h

Loading...

src/drive/teamdrivemodifyjob.h

Loading...

src/drive/teamdrivemodifyjob.cpp

Loading...