Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent
Adding necessary accessors and changing visibility of one slot.
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:1ff74854ecb4: Fix a todo: InformationPanelContent::configureSettings code is moved to…
1 compile
2 in dolphin right on the information panel
3 toggle preview
4 from the same context menu, click configure, metadadata settings appears
5 toggle "condensed date" if available
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- fix-todo
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9731 Build 9749: arc lint + arc unit
src/panels/information/informationpanel.cpp | ||
---|---|---|
167–168 | I'd put this code in a private function. | |
src/panels/information/informationpanelcontent.cpp | ||
51 | This can also be dropped now. | |
src/panels/information/informationpanelcontent.h | ||
75–77 | Please add a variable as argument | |
77 | We don't usually add const when a function returns a QList. |
src/panels/information/informationpanel.cpp | ||
---|---|---|
167–168 | See showContextMenu below |