Differential D19832

Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent
ClosedPublic
Actions

Authored by meven on Mar 17 2019, 4:28 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:1ff74854ecb4: Fix a todo: InformationPanelContent::configureSettings code is moved to…
Summary

Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent
Adding necessary accessors and changing visibility of one slot.

Test Plan

1 compile
2 in dolphin right on the information panel
3 toggle preview
4 from the same context menu, click configure, metadadata settings appears
5 toggle "condensed date" if available

Diff Detail

Repository
R318 Dolphin
Branch
fix-todo
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9726
Build 9744: arc lint + arc unit
meven created this revision.Mar 17 2019, 4:28 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 17 2019, 4:28 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Mar 17 2019, 4:28 PM
meven edited the summary of this revision. (Show Details)Mar 17 2019, 4:29 PM
meven retitled this revision from fix a todo to Fix a todo: InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent.
meven mentioned this in D19780: Fix a todo in Information Panel, fixing two bugs.
elvisangelaccio requested changes to this revision.Mar 17 2019, 5:30 PM
elvisangelaccio added inline comments.
src/panels/information/informationpanel.cpp
171–216

I'd put this code in a private function.

src/panels/information/informationpanelcontent.cpp
51

This can also be dropped now.

src/panels/information/informationpanelcontent.h
75

Please add a variable as argument

77

We don't usually add const when a function returns a QList.

This revision now requires changes to proceed.Mar 17 2019, 5:30 PM
meven updated this revision to Diff 54114.Mar 17 2019, 5:48 PM

Code review

meven marked 3 inline comments as done.Mar 17 2019, 5:50 PM
meven added inline comments.
src/panels/information/informationpanel.cpp
171–216

See showContextMenu below

meven marked 2 inline comments as done.Mar 17 2019, 5:50 PM
elvisangelaccio accepted this revision.EditedMar 17 2019, 5:58 PM

Please push to the Applications/19.04 branch.

This revision is now accepted and ready to land.Mar 17 2019, 5:58 PM
Closed by commit R318:1ff74854ecb4: Fix a todo: InformationPanelContent::configureSettings code is moved to… (authored by meven). · Explain WhyMar 17 2019, 6:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 54099

View Options

src/panels/information/informationpanel.cpp

Loading...
View Options

src/panels/information/informationpanelcontent.h

Loading...
View Options

src/panels/information/informationpanelcontent.cpp

Loading...