Differential D19828

[Kinit] Compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Mar 17 2019, 2:25 PM.

Tags

Subscribers

pino, kde-frameworks-devel

Details

Reviewers

Commits

R303:1b4c6832298c: [Kinit] Compile without foreach

Summary

compile without foreach

Test Plan

autotest ok

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent created this revision.Mar 17 2019, 2:25 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 17 2019, 2:25 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Mar 17 2019, 2:25 PM

Harbormaster completed remote builds in B9721: Diff 54091.Mar 17 2019, 2:25 PM

dfaure requested changes to this revision.Mar 17 2019, 8:09 PM

dfaure added inline comments.

src/kdeinit/kinit_win.cpp
440	How can this compile? The variable is called list instead of lst.

This revision now requires changes to proceed.Mar 17 2019, 8:09 PM

mlaurent added inline comments.Mar 17 2019, 10:09 PM

src/kdeinit/kinit_win.cpp
440	Windows code :) I can"t test it. thanks for pointing me it.

Fix typo

Harbormaster completed remote builds in B9770: Diff 54173.Mar 18 2019, 5:58 AM

mlaurent marked an inline comment as done.Mar 18 2019, 5:58 AM

pino added a subscriber: pino.Mar 18 2019, 7:42 AM

pino added inline comments.

src/kdeinit/kinit_win.cpp
300–301	qDeleteAll?
452	'lst' vs 'list'

Fix comment reported by Pino

Harbormaster completed remote builds in B9773: Diff 54177.Mar 18 2019, 8:19 AM

dfaure accepted this revision.Mar 18 2019, 8:23 AM

This revision is now accepted and ready to land.Mar 18 2019, 8:23 AM

Closed by commit R303:1b4c6832298c: [Kinit] Compile without foreach (authored by mlaurent). · Explain WhyMar 18 2019, 12:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			src/kdeinit/kinit.cpp (2 lines)
M			src/kdeinit/kinit_mac.mm (2 lines)
M			src/kdeinit/kinit_win.cpp (18 lines)
M			src/klauncher/autostart.cpp (6 lines)
M			src/klauncher/klauncher.cpp (36 lines)
M			src/kwrapper/kwrapper_win.cpp (9 lines)

Diff 54206

CMakeLists.txt

Loading...

src/kdeinit/kinit.cpp

Loading...

src/kdeinit/kinit_mac.mm

Loading...

src/kdeinit/kinit_win.cpp

Loading...

src/klauncher/autostart.cpp

Loading...

src/klauncher/klauncher.cpp

Loading...

src/kwrapper/kwrapper_win.cpp

Loading...