kns: Show subcategories for things that have one
ClosedPublic

Authored by apol on Mar 17 2019, 1:38 PM.

Details

Summary

Show subcategories for KNS resources that have more than 1 Category inside. At the moment it just is Wallpapers.

Diff Detail

Repository
R134 Discover Software Store
Branch
arcpatch-D19826_1
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9791
Build 9809: arc lint + arc unit
apol created this revision.Mar 17 2019, 1:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 17 2019, 1:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Mar 17 2019, 1:38 PM
apol planned changes to this revision.Mar 17 2019, 1:45 PM

Should look into whether it works for installed packages.

leinir requested changes to this revision.Mar 17 2019, 1:49 PM
leinir added a subscriber: leinir.

The rest looks nice and solid :)

libdiscover/backends/KNSBackend/KNSBackend.cpp
194

Don't think we need this, already creating the categories as Category instances just below, and we set the category on the Resource instance when we create that in ::resourceForEntry... With it we'd end up duplicating those categories in the list of categories for all resources, from what i can tell this line just isn't needed :)

apol updated this revision to Diff 54219.Mar 18 2019, 2:06 PM

Rebase and test with opendesktop apps

leinir accepted this revision.Mar 18 2019, 2:07 PM

Nifty :)

This revision is now accepted and ready to land.Mar 18 2019, 2:07 PM
This revision was automatically updated to reflect the committed changes.