Updated README.md with detailed build instructions
ClosedPublic

Authored by saishm on Mar 16 2019, 12:15 PM.

Details

Summary

Falkon introduction , building & contribution description added.
It will help new comers to build & contribute to the falkon easily.

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
saishm requested review of this revision.Mar 16 2019, 12:15 PM
saishm created this revision.
ognarb added a subscriber: ognarb.Mar 16 2019, 12:57 PM
ognarb added inline comments.
README.md
22

Maybe also creating a link to https://community.kde.org/Get_Involved could be good ;)

saishm updated this revision to Diff 54023.Mar 16 2019, 4:43 PM

You have to add full diff again, or it will not work.

saishm updated this revision to Diff 54031.Mar 16 2019, 6:29 PM
drosca requested changes to this revision.Mar 17 2019, 11:53 AM
drosca added inline comments.
README.md
2

Just mentioning that it is a KDE web browser and maybe also that it uses QtWebEngine is enough.

3–4

Please remove this whole Introduction part.

13

make && make install no sudo

16–17

This is wrong. You should always run the installed binary.

21
  • gcc: it also works with other compilers, remove this
  • cmake. should be spelled "CMake"
  • QT 5: should be spelled "Qt 5"

either use package names everywhere or nowhere

  • libxcb-util-dev: it's only dependency on Linux and only when not building with NO_X11
  • extra-cmake-modules: should be moved under cmake
  • libssl-dev: should be just OpenSSL
29

This applies to all dependencies, I don't think mentioning it only for Qt makes sense

This revision now requires changes to proceed.Mar 17 2019, 11:53 AM
saishm updated this revision to Diff 54083.Mar 17 2019, 1:26 PM

Removed Introduction section , fixed some typos & updated cutom prefix section

saishm updated this revision to Diff 54090.Mar 17 2019, 2:19 PM

now uploaded full diff

Alright, please tell me your full name + email and I'll commit part of this patch and adjust the rest myself.

I sent you my name & email id on irc

drosca accepted this revision.Mar 19 2019, 4:31 PM
This revision is now accepted and ready to land.Mar 19 2019, 4:31 PM
This revision was automatically updated to reflect the committed changes.