Differential D19800

[Application Dashboard] Improve mouse handler
ClosedPublic
Actions

Authored by trmdi on Mar 16 2019, 8:48 AM.

Details

Reviewers
hein
ngraham
Group Reviewers
Plasma
Commits
R119:0ecb1359eaca: [Application Dashboard] Improve mouse handler
Summary
  • Do not close Application Dashboard after dragging items
  • Correct the view attached property to GridView.view

BUG: 390424

Test Plan
  • Application Dashboard is not closed when dragging items in the Favorites column.

Diff Detail

Repository
R119 Plasma Desktop
Branch
fix-390424 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9654
Build 9672: arc lint + arc unit
trmdi created this revision.Mar 16 2019, 8:48 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 16 2019, 8:48 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Mar 16 2019, 8:48 AM
trmdi edited the summary of this revision. (Show Details)Mar 16 2019, 8:53 AM
ngraham added a comment.Mar 16 2019, 9:15 AM

While I can't get the bug to happen as often with this, I still can sometimes--especially when I drag the top-left-most item down one column.

This might need @hein's magic touch. :)

trmdi added a comment.Mar 16 2019, 9:18 AM
In D19800#431914, @ngraham wrote:

While I can't get the bug to happen as often with this, I still can sometimes--especially when I drag the top-left-most item down one column.

This might need @hein's magic touch. :)

I don't know how to reproduce it. Can you find an easy way to reproduce it?

ngraham added a comment.Mar 16 2019, 9:23 AM
In D19800#431915, @trmdi wrote:
In D19800#431914, @ngraham wrote:

While I can't get the bug to happen as often with this, I still can sometimes--especially when I drag the top-left-most item down one column.

This might need @hein's magic touch. :)

I don't know how to reproduce it. Can you find an easy way to reproduce it?

With this patch:

trmdi added a comment.Mar 16 2019, 12:35 PM

Ok, it will be fixed.

trmdi updated this revision to Diff 54052.EditedMar 17 2019, 1:18 AM

Improve the code.

@ngraham: Can you still reproduce it?

trmdi edited the summary of this revision. (Show Details)Mar 17 2019, 1:21 AM
hein accepted this revision.Mar 18 2019, 1:42 PM
This revision is now accepted and ready to land.Mar 18 2019, 1:42 PM
ngraham accepted this revision.Mar 18 2019, 2:38 PM

Yep, I can no longer reproduce the issue under any circumstances. Thanks a lot for fixing this!

ngraham added a comment.Mar 18 2019, 2:41 PM

Land on the Plasma/5.15 stable branch please: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

If you need a hand with that, let me know. :)

Closed by commit R119:0ecb1359eaca: [Application Dashboard] Improve mouse handler (authored by trmdi, committed by ngraham). · Explain WhyMar 18 2019, 3:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53992

View Options

applets/kicker/package/contents/ui/ItemGridView.qml

Loading...