Correcting the meridian flip function for situations where the meridian flip has been activated after a capture sequence without the meridian flip activated has been started.
Additionally, small corrections are added:
Expected result: the meridian flip is executed as soon as the meridian has been passed and the next capture has been finished. After the meridian flip, capturing is continued.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
setMeridianFlipValues is not a DBus function? doesn't need to be added to the Mount.xml file?
setMeridianFlipValues is not a DBus function? doesn't need to be added to the Mount.xml file?
No, I changed based the implementation on slots and signals. Changing a value in either capture or mount sends out a signal and the other side receives it and sets the values accordingly. This seems to me a more elegant way than using calls via DBus.
I think what Jasem means is that tab modules may work with slots and signals internally, but should communicate between each other with dbus. Just as if they were independent processes, possibly distributed over different machines.
OK, understood. I will change the signal handling such that they are using the D-Bus.
So a lot of signal/slots are already connected between all the modules now. There is no direct cables between them, it only happens via signal/slots. But we should exposure DBus where it make sense as well. At any rate, is this good to go now and reliable?