Apply the KDE HIG, move the KCM below the Application Style KCM, update strings, fix inconsistencies and make the KCM look better.
Details
Details
- Reviewers
apol ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
- Commits
- R99:36dd29f8b65a: Improve the look of the GTK Application Style KCM UI
Open the GTK Application Style KCM.
Diff Detail
Diff Detail
- Repository
- R99 KDE Gtk Configuration Tool
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9656 Build 9674: arc lint + arc unit
kde-gtk-config.desktop | ||
---|---|---|
1–2 | I'll remove the things that weren't here before, but this is just sorting the desktop entry to make it consistent with other KCM desktop files. | |
58 | Will remove those, just copied it from the Application Style KCM. | |
src/gtkconfigkcmodule.cpp | ||
65–66 | This is making it consistent with other KCMs. |
Comment Actions
I'm not a fan of changing the name to remove "GNOME" from it. GTK is a UI toolkit whose name is not familiar to many of our users; adding "GNOME" to it makes the purpose clearer.
Ideally what I'd like to see is that the Qt and GTK KCMs have the following names:
- KDE & Qt Application Style
- GNOME & GTK Application Style
This is what we agreed to on T8871.