Improve the look of the GTK Application Style KCM UI
ClosedPublic

Authored by GB_2 on Mar 15 2019, 4:35 PM.

Details

Summary

Apply the KDE HIG, move the KCM below the Application Style KCM, update strings, fix inconsistencies and make the KCM look better.

Test Plan

Open the GTK Application Style KCM.

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Mar 15 2019, 4:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 15 2019, 4:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Mar 15 2019, 4:35 PM
apol added a subscriber: apol.Mar 15 2019, 6:44 PM
apol added inline comments.
kde-gtk-config.desktop
1–13

All this not saying they're right or wrong but unrelated to the change at stake.

58

How is "text" or "highlight" relevant to this?

src/gtkconfigkcmodule.cpp
65–66

Unrelated.

GB_2 edited the summary of this revision. (Show Details)Mar 16 2019, 8:28 AM
GB_2 added inline comments.Mar 16 2019, 8:39 AM
kde-gtk-config.desktop
1–13

I'll remove the things that weren't here before, but this is just sorting the desktop entry to make it consistent with other KCM desktop files.

58

Will remove those, just copied it from the Application Style KCM.

src/gtkconfigkcmodule.cpp
65–66

This is making it consistent with other KCMs.

GB_2 edited the summary of this revision. (Show Details)Mar 16 2019, 8:40 AM
GB_2 updated this revision to Diff 53994.Mar 16 2019, 9:06 AM

Clean desktop file

GB_2 marked 6 inline comments as done.Mar 16 2019, 9:08 AM
apol added inline comments.Mar 16 2019, 9:33 AM
kde-gtk-config.desktop
58

Then do it so I can accept the patch

src/gtkconfigkcmodule.cpp
65–66

That's fine, but you can do it in a separate patch.

GB_2 added inline comments.Mar 16 2019, 10:22 AM
kde-gtk-config.desktop
58

I already did it.

src/gtkconfigkcmodule.cpp
65–66

I'm already updating the strings here. I always did this in other KCMs too.

apol accepted this revision.Mar 16 2019, 11:24 AM
This revision is now accepted and ready to land.Mar 16 2019, 11:24 AM
GB_2 marked 4 inline comments as done.Mar 16 2019, 12:31 PM
ngraham requested changes to this revision.Mar 16 2019, 4:12 PM
ngraham added a subscriber: ngraham.

I'm not a fan of changing the name to remove "GNOME" from it. GTK is a UI toolkit whose name is not familiar to many of our users; adding "GNOME" to it makes the purpose clearer.

Ideally what I'd like to see is that the Qt and GTK KCMs have the following names:

  • KDE & Qt Application Style
  • GNOME & GTK Application Style

This is what we agreed to on T8871.

This revision now requires changes to proceed.Mar 16 2019, 4:12 PM
GB_2 updated this revision to Diff 54026.Mar 16 2019, 5:33 PM

Add back word GNOME and update GHNS button tooltip

GB_2 edited the summary of this revision. (Show Details)Mar 16 2019, 5:34 PM
GB_2 updated this revision to Diff 54032.Mar 16 2019, 6:35 PM

Improve and clean UI

GB_2 edited the summary of this revision. (Show Details)Mar 16 2019, 6:35 PM
GB_2 updated this revision to Diff 54033.Mar 16 2019, 6:46 PM

Fix groupbox widths

GB_2 edited the summary of this revision. (Show Details)Mar 16 2019, 6:54 PM
ngraham accepted this revision.Mar 16 2019, 9:01 PM

Thanks, this is good to go now!

This revision is now accepted and ready to land.Mar 16 2019, 9:01 PM
This revision was automatically updated to reflect the committed changes.