[service runner] throw out kde3 "compat" code
ClosedPublic

Authored by sitter on Mar 15 2019, 2:47 PM.

Details

Summary

Desktop files such as kde/foo.desktop are identified as kde-foo.desktop
because of the menu spec

If the directory contains sub-directories then these sub-directories should be (recursively) scanned as well. The name of the subdirectory should be added as prefix to the desktop-file id together with a dash character ("-")

the runner therefore broadly assumed that kde-foo.desktop is always
the desktop file kde/foo.desktop and since kde/ was only used up to KDE3
this assumption formed the basis for sepcial KDE3 compat handling. that is
of course wrong because a service might just as well actually have a
prefix and be actually called kde-foo.desktop rather than
kde/foo.desktop. Specific example: kde-gtk-config.desktop

seeing as this is ancient compatibility code that is actually wrong,
the easiest solution seems to be dropping the code entirely (and thus no
longer assume kde- has some special meaning).

(also I didn't find a way to get the underlying filename of a kservice,
so making the code not wrong seems non-trivial)

CHANGELOG: the GTK+ settings module now correctly appears in krunner and kickoff
BUG: 383287

Test Plan

gtk kcm correctly shows up in both kickoff and krunner searches

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 15 2019, 2:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 15 2019, 2:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 15 2019, 2:47 PM
sitter retitled this revision from [service runner] throw out kde3 "compat" code for KCMs to [service runner] throw out kde3 "compat" code.
GB_2 added a subscriber: GB_2.Mar 15 2019, 3:02 PM

This is bug 383287

broulik accepted this revision.Mar 16 2019, 9:29 AM
This revision is now accepted and ready to land.Mar 16 2019, 9:29 AM
GB_2 edited the summary of this revision. (Show Details)Mar 16 2019, 5:28 PM
GB_2 edited the summary of this revision. (Show Details)Mar 17 2019, 1:26 PM
sitter edited the summary of this revision. (Show Details)Mar 18 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.