Differential D19781

[platforms/drm] Add DPI connector type
ClosedPublic
Actions

Authored by zzag on Mar 15 2019, 11:09 AM.

Details

Reviewers
apol
davidedmundson
Group Reviewers
KWin
Commits
R108:380c93ac19f5: [platforms/drm] Add DPI connector type

Diff Detail

Repository
R108 KWin
Branch
dpi-connecotr
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9620
Build 9638: arc lint + arc unit
zzag created this revision.Mar 15 2019, 11:09 AM
Restricted Application added a project: KWin. · View Herald TranscriptMar 15 2019, 11:09 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mar 15 2019, 11:09 AM
apol added a subscriber: apol.Mar 15 2019, 6:36 PM

Otherwise LGTM

plugins/platforms/drm/drm_output.cpp
194

This coma in the end is wrong.

zzag added inline comments.Mar 15 2019, 7:03 PM
plugins/platforms/drm/drm_output.cpp
194

Why?

apol accepted this revision.Mar 16 2019, 9:24 AM
apol added inline comments.
plugins/platforms/drm/drm_output.cpp
194

I'm sorry, researched further and saw it is fine as of c++11.
Complaint withdrawn.

This revision is now accepted and ready to land.Mar 16 2019, 9:24 AM
davidedmundson accepted this revision.Mar 18 2019, 1:52 PM
Closed by commit R108:380c93ac19f5: [platforms/drm] Add DPI connector type (authored by zzag). · Explain WhyMar 19 2019, 4:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53946

View Options

plugins/platforms/drm/drm_output.cpp

Loading...