Fix a TODO : InformationPanelContent::configureSettings code is moved to InformationPanel::contextMenuEvent
Fix two bugs relating to preview window being shown when they should not.
Avoid computing previews when they are hidden.
Bugs examples :
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin
Test the preview especially with videos.
Select a video with the preview on, play the video, toggle on and off the preview using the context menu.
Select a video file with a video file selected, disable the preview
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- fix-preview
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9681 Build 9699: arc lint + arc unit
| src/panels/information/informationpanel.cpp | ||
|---|---|---|
| 168–214 | Do not parent object on the stack, if its parent gets destroyed before, destructor will be called twice. | |
| src/panels/information/informationpanel.cpp | ||
|---|---|---|
| 168–214 | This means I should use Qmenu popup(parent) ? | |
Comment Actions
I realize the review could be easier to get into.
I can split the actual refactoring involving the TODO and the bug fix in two reviews if anyone would feel the need.
Comment Actions
Can you please split this patch into two or more? One for the code refactoring and another one for each bug you are fixing, describing how to reproduce the issue and how we are going to fix it.
Comment Actions
Sure.
First patch is at D19832
The other will depend on this one, so I will for this to go through before opening the bug fixes patchs