Use ellipsis in search field
ClosedPublic

Authored by ognarb on Mar 14 2019, 11:32 PM.

Details

Summary

Screenshot:

Test Plan

Build, run and search field work as before

Diff Detail

Repository
R326 Kalzium
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Mar 14 2019, 11:32 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 14 2019, 11:32 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
ognarb requested review of this revision.Mar 14 2019, 11:32 PM
ngraham added inline comments.
src/searchwidget.cpp
40

Typically we use three periods for this, not the actual ellipsis character. I don't know why, but what's what we do. :)

ognarb added inline comments.
src/searchwidget.cpp
40

In this case, we need to fix the HIG, because the symbol in the HIG is the unicode ellipsis. Also, @yurchor say GNOME also use the unicode ellipsis.

aacid added a subscriber: aacid.Mar 16 2019, 12:03 AM

Has the HIG updated and decided the search label needs to be removed? Anyone has a pointer as to why anyone would do that when there's no scarcity of horizontal space?

ognarb updated this revision to Diff 54136.Mar 17 2019, 7:12 PM

Use 3 dots instead of the unicode ellipsis

yurchor accepted this revision.Mar 17 2019, 7:14 PM
This revision is now accepted and ready to land.Mar 17 2019, 7:14 PM
This revision was automatically updated to reflect the committed changes.
aacid added a comment.Mar 17 2019, 8:24 PM

I wish you used proper commit logs, this is not "Use ellipsis in the search field" this is "Remove search label and replace it by a placeholder"

You may not think of it, but this commit logs are going to be read by people in 10 years and them being accurate is quite important.

And also, stop removing buddies! You're making the line edits inaccessible by using the keyboard when before they were, that's a major usability regression

I wish you used proper commit logs, this is not "Use ellipsis in the search field" this is "Remove search label and replace it by a placeholder"

You may not think of it, but this commit logs are going to be read by people in 10 years and them being accurate is quite important.

Sorry about that, I will use better titles in the future.

And also, stop removing buddies! You're making the line edits inaccessible by using the keyboard when before they were, that's a major usability regression

I don't understand the problem, I can still use tab to go to the line edit. Or are they some other shortcuts that I don't know yet?

aacid added a comment.Mar 17 2019, 8:48 PM

I wish you used proper commit logs, this is not "Use ellipsis in the search field" this is "Remove search label and replace it by a placeholder"

You may not think of it, but this commit logs are going to be read by people in 10 years and them being accurate is quite important.

Sorry about that, I will use better titles in the future.

And also, stop removing buddies! You're making the line edits inaccessible by using the keyboard when before they were, that's a major usability regression

I don't understand the problem, I can still use tab to go to the line edit. Or are they some other shortcuts that I don't know yet?

Buddies are not about tabbing, buddies are keyboard accelerators. See https://i.imgur.com/ztGaCW5.gif

It's a bit basic, but pressing Alt+H will focus the buddy of the Hello label and pressing Alt+T will focus the buddy of the There label. If you remove the labels you can't Alt+Anything to focus on the line edits

We're trying to use a consistent visual style throughout KDE software, which means no buddies for search fields.

I understand your point that this means the search field is no longer accessible via an alt-key accelerator, and I agree that this is a functional regression. Is there any way we can get the benefits of both? Can we assign the search field itself a consistent alt-key accelerator?

Can we assign the search field itself a consistent alt-key accelerator?

Yes, you can use a buddy :)

How would you even show which alt-key accelerator to use if there's no buddy?

Just thinking out loud here, but when there's no buddy and there is placeholder text, the text field's placeholder text could show an underline under one of its letters just like the buddy does.

bruns added a subscriber: bruns.Aug 17 2019, 1:24 PM
bruns added inline comments.
src/searchwidget.cpp
40

In the past, the original text often used just 3 dots and the translation used an ellipsis (one of the few places where the en_XX translation is not a noop). I am not sure if this still applies.