Differential D19769

Bug 404162 File/Save acts always acts like "Save as..."
ClosedPublic
Actions

Authored by krutovmikhail on Mar 14 2019, 7:44 PM.

Details

Reviewers
aacid
Commits
R337:036fffed7ae1: Fix File/Save acts always acts like "Save as..."
Summary

Slight reformatting and fixing the Save As junior job bug

Diff Detail

Repository
R337 KTurtle
Branch
20190314/jj-fix/mkr/saveas (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9597
Build 9615: arc lint + arc unit
krutovmikhail created this revision.Mar 14 2019, 7:44 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 14 2019, 7:44 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
krutovmikhail requested review of this revision.Mar 14 2019, 7:44 PM
krutovmikhail updated this revision to Diff 53916.Mar 14 2019, 7:53 PM

Updating D19769: Bug 404162 File/Save acts always acts like "Save as..."

krutovmikhail updated this revision to Diff 53917.Mar 14 2019, 7:55 PM

Updating D19769: Bug 404162 File/Save acts always acts like "Save as..."

aacid added a subscriber: aacid.Mar 14 2019, 8:51 PM
aacid added inline comments.
src/editor.cpp
264

indentation on lines 263 and 265 feels weird, there's two } on the same horizontal line, probably the one above needs to be indented?

apol added a subscriber: apol.Mar 15 2019, 6:00 PM
apol added inline comments.
src/editor.cpp
248

We shouldn't use exclamation marks on GUIs.
https://hig.kde.org/style/writing/wording.html

krutovmikhail updated this revision to Diff 53980.Mar 15 2019, 10:13 PM
  • Update per phabricator comments: message wording & indention
aacid accepted this revision.Mar 17 2019, 10:54 PM

Awesome job :)

I'll land it just now.

This revision is now accepted and ready to land.Mar 17 2019, 10:54 PM
Closed by commit R337:036fffed7ae1: Fix File/Save acts always acts like "Save as..." (authored by krutovmikhail, committed by aacid). · Explain WhyMar 17 2019, 10:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/editor.cpp (34 lines)

Diff 53917

View Options

src/editor.cpp

Loading...