Differential D19768

Fixes memory leak of ssh_session
ClosedPublic
Actions

Authored by hallas on Mar 14 2019, 7:09 PM.

Details

Reviewers
sitter
aacid
Group Reviewers
Frameworks
Commits
R320:b85ec7a551ea: Fixes memory leak of ssh_session
Summary

Fixes memory leak of ssh_session. The mSession member variable is
allocated with a call to ssh_new in sftpOpenConnection but in the
closeConnection a call to ssh_free was missing causing the ssh_session
to be leaked.

Test Plan

Build and run kio_sftp with address sanitizer

Diff Detail

Repository
R320 KIO Extras
Branch
fixes_memory_leak_of_session (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9592
Build 9610: arc lint + arc unit
hallas created this revision.Mar 14 2019, 7:09 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptMar 14 2019, 7:09 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
hallas requested review of this revision.Mar 14 2019, 7:09 PM
aacid accepted this revision.Mar 14 2019, 9:02 PM
This revision is now accepted and ready to land.Mar 14 2019, 9:02 PM
hallas closed this revision.Mar 15 2019, 5:05 AM

Revision Contents
Changeset List

PathPackages
Msftp/kio_sftp.cpp (1 line)

Diff 53912

View Options

sftp/kio_sftp.cpp

Loading...