Differential D19763

[Desktop Theme KCM] Emit current index change when resetting the model
ClosedPublic
Actions

Authored by broulik on Mar 14 2019, 4:20 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R119:fa99dfb2fd7a: [Desktop Theme KCM] Emit current index change when resetting the model
Summary

When the model is reset, GridView invalidates its currentIndex resulting in no theme being selected.

Test Plan

Installed a new theme via GHNS, "Breeze" was still highlighted as current. Before none was highlighted.
Verified that Apply button isn't erroneously activated

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 14 2019, 4:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 14 2019, 4:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 14 2019, 4:20 PM
ngraham accepted this revision.Mar 14 2019, 5:26 PM
This revision is now accepted and ready to land.Mar 14 2019, 5:26 PM
Closed by commit R119:fa99dfb2fd7a: [Desktop Theme KCM] Emit current index change when resetting the model (authored by broulik). · Explain WhyMar 14 2019, 9:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/desktoptheme/kcm.cpp (2 lines)

Diff 53924

View Options

kcms/desktoptheme/kcm.cpp

Loading...