- New MIDebuggerPlugin, which GDB::CppDebuggerPlugin now inherits from
- Solve old TODOs in GDB::CppDebuggerPlugin
- Move debuggers/gdb/debugjob.* to debuggers/common/midebugjobs.*
- New MIExamineCoreJob and MIAttachProcessJob
- Move process selection dialog and select core dialog to common
Details
Details
- Reviewers
apol - Group Reviewers
KDevelop - Commits
- R32:97bb04342a2d: Prepare for lldb plugin: move code from gdb debugger plugin to common one.
unit tests under gdb folder
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I'm a bit afraid you might be trying to abstract things out a bit too much. it's ok if GDB and LLDB have some similar code...
debuggers/common/midebuggerplugin.cpp | ||
---|---|---|
75 | What's with the commented code? |
Comment Actions
But the logic is exactly the same for gdb and lldb to setup drkonqi and menu actions. Most difference between gdb and lldb is handled in their own DebugSession.
debuggers/common/midebuggerplugin.cpp | ||
---|---|---|
75 | It's handled in GDB::CppDebuggerPlugin right now. As it's mostly UI code and I don't want to touch it before lldb plugin is feature complete to some extent. |
Comment Actions
And most tool views requires a pointer to the plugin. A common base class can avoid have different ui class for gdb and lldb.
Comment Actions
Sure, I'll think about it again. Actually I also have the feeling that I might be sharing too much code between lldb and gdb.