Differential D19758

Data source can be obtained by ID
ClosedPublic
Actions

Authored by vitalyf on Mar 14 2019, 12:29 PM.

Details

Reviewers
vkrause
Commits
R849:0858b9deb45b: Data source can be obtained by ID
Summary

It allows to perform fast look up when needed

Diff Detail

Repository
R849 User Feedback Collection Framework
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vitalyf requested review of this revision.Mar 14 2019, 12:29 PM
vitalyf created this revision.
vkrause added inline comments.Mar 14 2019, 5:34 PM
src/provider/core/provider.h
189

I think the more Qt-like API would be to not use the "find" prefix and just call this dataSource(const QString &id)?

vitalyf added inline comments.Mar 15 2019, 8:42 AM
src/provider/core/provider.h
189

Well, we have actually both styles. But I agree, that for this case omitting prefix is better choice.
I'll change this.

vitalyf updated this revision to Diff 53943.Mar 15 2019, 10:07 AM

Changed the method name and added unit test covers lookup functionality.

vkrause accepted this revision.Mar 15 2019, 10:11 AM

Thanks!

This revision is now accepted and ready to land.Mar 15 2019, 10:11 AM
Closed by commit R849:0858b9deb45b: Data source can be obtained by ID (authored by vitalyf, committed by vkrause). · Explain WhyMar 15 2019, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53966

View Options

autotests/providertest.cpp

Loading...
View Options

src/provider/core/provider.h

Loading...
View Options

src/provider/core/provider.cpp

Loading...
View Options

src/provider/core/provider_p.h

Loading...