[KSplashQML] Register DBus before loading the splash theme
ClosedPublic

Authored by broulik on Mar 14 2019, 9:47 AM.

Details

Summary

Loading the theme and setting everything up can take a while.
Ensure that we catch all setStage calls that might have been emitted before we were fully up.

CCBUG: 405444

Test Plan

Sabotaged my ksplash theme to take forever to load, did a qdbus setstage call, once ksplash came up and processed the dbus call, the stage immediately advanced without any obvious sideeffects

It's important that the setStage calls are issued without blocking, but startkde script does fire-and-forget, KWin, KSMServer, and Plasma issue an asyncCall,

It is still somewhat racy as startkde launches ksplash --pid which then forks and returns the PID, so there's still a window between startkde reaching the point where it calls kinit has launched and KSplash has started up

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 14 2019, 9:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 14 2019, 9:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 14 2019, 9:47 AM
broulik edited the test plan for this revision. (Show Details)Mar 14 2019, 9:51 AM
broulik edited the test plan for this revision. (Show Details)Mar 14 2019, 10:46 AM
mart accepted this revision.Mar 16 2019, 11:21 AM
This revision is now accepted and ready to land.Mar 16 2019, 11:21 AM
This revision was automatically updated to reflect the committed changes.