[attica] compile without foreach
ClosedPublic

Authored by mlaurent on Mar 14 2019, 7:58 AM.

Details

Summary

compile without foreach

Test Plan

autotest ok

Diff Detail

Repository
R235 Attica
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Mar 14 2019, 7:58 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 14 2019, 7:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Mar 14 2019, 7:58 AM

Everything else looks OK.

src/providermanager.cpp
106–107

the variable could be better named, like providerFiles or just files
(these are files, not providers)

mlaurent updated this revision to Diff 54075.Mar 17 2019, 10:52 AM

Rename variable

dfaure accepted this revision.Mar 17 2019, 7:56 PM
This revision is now accepted and ready to land.Mar 17 2019, 7:56 PM
This revision was automatically updated to reflect the committed changes.