Differential D19746

[lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
ClosedPublic
Actions

Authored by filipf on Mar 14 2019, 5:08 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R120:cef563e560ac: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
Summary

This patch ports lock-logout's configuration window to QQC2 and Kirigami.FormLayout.

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9563
Build 9581: arc lint + arc unit
filipf created this revision.Mar 14 2019, 5:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 14 2019, 5:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 14 2019, 5:08 AM
filipf edited the summary of this revision. (Show Details)Mar 14 2019, 5:09 AM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, VDG, ngraham.
ngraham requested changes to this revision.Mar 14 2019, 5:12 AM
ngraham added inline comments.
applets/lock_logout/contents/ui/ConfigGeneral.qml
72

The original was correct :)

This revision now requires changes to proceed.Mar 14 2019, 5:12 AM
filipf updated this revision to Diff 53853.Mar 14 2019, 5:40 AM

suspend -> sleep

filipf marked an inline comment as done.Mar 14 2019, 5:41 AM

Forgot about that :)

There's still strings to fix in the main qml file for this applet (lockout.qml).

filipf updated this revision to Diff 53858.Mar 14 2019, 7:10 AM

actually fix the "sleep" string

filipf added a comment.EditedMar 14 2019, 7:11 AM

Ignore the previous comment, I was working on an older template.

ngraham accepted this revision.Mar 14 2019, 2:08 PM
This revision is now accepted and ready to land.Mar 14 2019, 2:08 PM
Closed by commit R120:cef563e560ac: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). · Explain WhyMar 14 2019, 10:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53853

View Options

applets/lock_logout/contents/ui/ConfigGeneral.qml

Loading...