For some feeds (linuxfr.org for instance), the links in the feed are
relative to the feed URI (for instance, //linuxfr.org/some/content).
These links were broken by the forced baseUri of file://. It is better to
instead use the feed uri as the base.
Details
Details
- Reviewers
mlaurent - Group Reviewers
KDE PIM - Commits
- R201:fbd04c0045a5: Make the feed uri the baseUrl for previews
Diff Detail
Diff Detail
- Repository
- R201 Akregator
- Branch
- fixBaseUrl
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9874 Build 9892: arc lint + arc unit
src/articleviewerwidget.cpp | ||
---|---|---|
196 | Are you sure that article.feed()->xmlUrl() is never null ? |
src/articleviewerwidget.cpp | ||
---|---|---|
196 | 100% sure. See feed.cpp line 146 where Feeds are instanciated from OPML. Otherwise, they are instanciated when added by URL. Having it null would be terrible about everywhere in the codebase I think. |
src/articleviewerwidget.cpp | ||
---|---|---|
196 | Ok add a const QUrl xmlUrl = QUrl(article.feed()->xmlUrl()); so we can debug it if there is a wierd url. Thanks |
Comment Actions
- Drop reference to .css files that do not exist
- Output the xmlUri to help debug, as asked by mlaurent
Comment Actions
I fixed for mlaurent.
I also fixed a new warning about the .css files that do not exist. Previously, they generated silent errors, but now that the baseUrl does not allow by default file:// urls, it appears in the program output.