Fix "Add Network Folder" tooltip icon does not show on Breeze, shows correctly
on Breeze Dark. The fix is taken from D19596.
Details
- Reviewers
elvisangelaccio ngraham - Group Reviewers
Dolphin - Commits
- R318:508dc815c75c: Fix "Add Network Folder" tooltip icon does not show on Breeze, shows correctly…
Open Dolphin with the Breeze theme
Hover the mouse over the "Add Network Folder"
The icon is black on black
BUG: 404858
Diff Detail
- Repository
- R318 Dolphin
- Branch
- fix_add_network_folder_icon_color (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9548 Build 9566: arc lint + arc unit
I suppose since creating a KIconLoader instance is quite heavy (parses all the theme directories and so on) we surely don't want to do that every time a tooltip is requested.
(However, isn't ToolTipManager a singleton of its own already?)
Honestly I didn't give it much thought, I basically "ported" the fix from D19596. But I can see that ToolTipManager is not a singleton, it is dynamically allocated by DolphinView, so I think it is a good idea to keep KIconLoader as a singleton so that we keep a single instance across all Dolphin views.
We definitively don't want to create a KIconLoader every time the user hovers a file.
@elvisangelaccio - Should this be pushed to Applications/19.04 and then merged to master ? Or only pushed to master?