Differential D19729

[kcmkwin/kwindecoration] Use new API to set cell size properly
ClosedPublic
Actions

Authored by broulik on Mar 13 2019, 3:05 PM.

Details

Reviewers
vpilo
Group Reviewers
KWin
Commits
R108:bc25e7c4748b: [kcmkwin/kwindecoration] Use new API to set cell size properly
Summary

Thanks to 5cfdbaa4b081a030a01477fd13c20f710fe58d4b the implicitCellWidth and implicitCellHeight of the GridView can be adjusted without hacks.

Test Plan


Delegates spread out horizontally now like they do in the other KCMs

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 13 2019, 3:05 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 13 2019, 3:05 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Mar 13 2019, 3:05 PM
vpilo added a comment.Mar 13 2019, 5:40 PM

No need to bump versions of org.kde.kcm ?

broulik added a comment.Mar 13 2019, 10:19 PM

No, (unfortunately) you can't version properties defined in pure QML

vpilo accepted this revision.Mar 14 2019, 8:33 AM

Then I don't know what the import versions are about any more :P

This revision is now accepted and ready to land.Mar 14 2019, 8:33 AM
Closed by commit R108:bc25e7c4748b: [kcmkwin/kwindecoration] Use new API to set cell size properly (authored by broulik). · Explain WhyMar 14 2019, 8:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53861

View Options

kcmkwin/kwindecoration/package/contents/ui/Themes.qml

Loading...