[effects/fallapart] Override scale, fade, and glide effect
ClosedPublic

Authored by zzag on Mar 13 2019, 11:29 AM.

Details

Summary

Currently the fall apart effect doesn't work in conjuction with window
open/close animation effects, e.g. scale. The reason for that is those
effects grab windows before the fall apart effect.

Test Plan
  • Enable the fall apart effect and the scale effect;
  • Close a window.

(without this patch the window doesn't fall apart)

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Mar 13 2019, 11:29 AM
Restricted Application added a project: KWin. · View Herald TranscriptMar 13 2019, 11:29 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mar 13 2019, 11:29 AM
davidedmundson accepted this revision.Nov 12 2019, 12:36 PM
davidedmundson added a subscriber: davidedmundson.

It feels like we should have a better way of doing grabs that can follow a specified ordering instead of N effects jumping in and fighting over it at random.
Something for another day though.

This revision is now accepted and ready to land.Nov 12 2019, 12:36 PM
ngraham added a subscriber: ngraham.Dec 5 2019, 8:54 PM

Can this land?

This revision was automatically updated to reflect the committed changes.