Modify Style::drawFrameLineEditPrimitive to use the brush rather than the color to fill the background of line edits. This is more correct in some corner cases where the brush is not a solid color.
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R113 Oxygen Theme
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Note: this is "inspired" by qtColorButton, which uses a textured brush for colors with non-opaque alpha. This renders correctly with built-in styles, but not with current Oxygen. (I have a sneaking suspicion that it used to work, however, as I'm pretty sure I've been using oxygen since well before I wrote qtColorButton.)
kstyle/oxygenstyle.cpp | ||
---|---|---|
3273 | Why the reference? |
kstyle/oxygenstyle.cpp | ||
---|---|---|
3273 | Force of habit... supposedly it forces copy elision (although new C++ is trying to make that happen regardless). Same pattern is used for rect and palette a couple lines above here. Note: https://herbsutter.com/2008/01/01/gotw-88-a-candidate-for-the-most-important-const/ |