I'm still not quite sure what exactly we have to do when a client is unmapped. Should we send a configure event?

No-one actually unmaps and remaps the same shellclient IRL, so it's kinda moot.

In theory we shouldn't send anything till we get the next commit event on the wl_surface.

So arguably we should do something like

ShellClient::unmap() {
    if (xdg) {
        m_requestGeometryBlockCounter++;
        connect(s, &SurfaceInterface::committed, this, &ShellClient::finishInit);
    }
     //existing code
}

but that's true before this patch