Make QQC2 desktop style a RUNTIME dependency
ClosedPublic

Authored by broulik on Mar 12 2019, 11:52 AM.

Details

Summary

Should avoid cases of "my settings look ugly" because it is not installed

Test Plan
-- The following RUNTIME packages have been found:

 * KF5Kirigami2 (required version >= 5.56.0), A QtQuick based components set
   Required at runtime by many KCMs
 * KF5QQC2DeskopStyle (required version >= 5.56.0), QtQuickControls 2 style that uses QWidget's QStyle for painting
   Required at runtime by many KCMs

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 12 2019, 11:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 12 2019, 11:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 12 2019, 11:52 AM
fvogt added inline comments.Mar 12 2019, 12:49 PM
CMakeLists.txt
68

IIRC not only KCMs, but also some other dialogs

broulik added inline comments.Mar 12 2019, 1:29 PM
CMakeLists.txt
68

I just copied that over from the line above :) Plasma config dialogs also loosely qualify as KCMs

ngraham accepted this revision.Mar 12 2019, 1:32 PM
ngraham added a subscriber: ngraham.

+1 for concept, functionality, and execution. Use whatever string seems most appropriate to you, I say. :)

This revision is now accepted and ready to land.Mar 12 2019, 1:32 PM
fvogt accepted this revision.Mar 12 2019, 2:10 PM
This revision was automatically updated to reflect the committed changes.