Differential D19698

Remove crash in plasmashell
ClosedPublic
Actions

Authored by mlaurent on Mar 12 2019, 6:03 AM.

Details

Reviewers
dfaure
broulik
Group Reviewers
Frameworks
Plasma
Commits
R242:ebae2d630336: Remove crash in plasmashell
R242:c634c4770b97: Remove crash in plasmashell
Summary

remove bug in plasmashell Bug 405341

Test Plan

can't reproduce bug

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
remove_crash_bug_405351 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9493
Build 9511: arc lint + arc unit
mlaurent created this revision.Mar 12 2019, 6:03 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 12 2019, 6:03 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Mar 12 2019, 6:03 AM
broulik requested changes to this revision.Mar 12 2019, 7:56 AM
broulik added a subscriber: broulik.
broulik added inline comments.
src/declarativeimports/core/datamodel.cpp
67–70

Coding style, braces also for single line statements

This revision now requires changes to proceed.Mar 12 2019, 7:56 AM
mlaurent updated this revision to Diff 53707.Mar 12 2019, 8:07 AM

Fix coding style

broulik accepted this revision.Mar 12 2019, 8:07 AM
This revision is now accepted and ready to land.Mar 12 2019, 8:07 AM
Closed by commit R242:ebae2d630336: Remove crash in plasmashell (authored by mlaurent). · Explain WhyMar 12 2019, 9:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53707

View Options

src/declarativeimports/core/datamodel.cpp

Loading...