Differential D19684

drop explicit disconnect in dtor
ClosedPublic
Actions

Authored by sitter on Mar 11 2019, 3:07 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:f7fbcff86ac4: drop explicit disconnect in dtor
Summary

when this is getting destroyed the qobject dtor will automatically
disconnect everything. the explicit disconnect calls serve no purpose and
aren't done in any other dtors.

Test Plan

it doesn't crash

Diff Detail

Repository
R871 DrKonqi
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9471
Build 9489: arc lint + arc unit
sitter created this revision.Mar 11 2019, 3:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 11 2019, 3:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 11 2019, 3:07 PM
broulik accepted this revision.Mar 11 2019, 3:09 PM
This revision is now accepted and ready to land.Mar 11 2019, 3:09 PM
Closed by commit R871:f7fbcff86ac4: drop explicit disconnect in dtor (authored by sitter). · Explain WhyMar 11 2019, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53662

View Options

src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp

Loading...