Do not use SYSTEM when including header paths
ClosedPublic

Authored by hannahk on Mar 11 2019, 10:49 AM.

Details

Summary

Using SYSTEM here forces CMake to pass -isystem to gcc.
This breaks crosscompiling on multiple occasions
This incorrectly tells gcc that BluezQt include dir is of system inportance

Test Plan

Crosscompiling with KDE Yocto project to raspberrypi3

Diff Detail

Repository
R97 Bluedevil
Lint
Lint Skipped
Unit
Unit Tests Skipped
hannahk created this revision.Mar 11 2019, 10:49 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 11 2019, 10:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hannahk requested review of this revision.Mar 11 2019, 10:49 AM
hannahk added a reviewer: Plasma.
apol accepted this revision.Mar 11 2019, 12:44 PM
This revision is now accepted and ready to land.Mar 11 2019, 12:44 PM
This revision was automatically updated to reflect the committed changes.
hannahk added a comment.EditedMar 11 2019, 12:59 PM

I don't have commit access
Plz push this with: Hannah Kiekens hannahkiekens@gmail.com

OH- that happened already, THX