| apol | |
| kfunk | |
| mwolff |
When using gtest_discover_tests(), add_test() directives are present in various .cmake files. To date, Kdevelop searches for unit-tests does not follow include() directives present in the main CTestTestfile.cmake, leading to no unit-tests being shown.
Additionally, the bracket arguments of CMake is not enabled for parsing tests arguments.
This patch enables them, and follows include() directives.
| Lint Skipped |
| Unit Tests Skipped |
great! can we get a unit test for this? though I'm unsure if we ever revived the unit tests from our old cmake integration
I've some small style nits, but otherwise +1
| plugins/cmake/cmakeutils.cpp | ||
|---|---|---|
| 694 | then add this function here (with the style fixes mentioned above), and have importTestSuites defer to it via QVector<Test> importTestSuites(const Path &buildDir)
{
return importTestSuites(buildDir, QStringLiteral("CTestTestfile.cmake"));
} | |
| 696 | const and lower-case the start | |
| 714 | QString() or {} instead of empty string literal | |
| plugins/cmake/cmakeutils.h | ||
| 265 | remove space after &, but add spaces around = and lower-case the cmakeTestFileName looking below, it would probably be better to split this up, i.e. only keep the importTestSuites public that takes only a Path (i.e. the old API) | |
Regarding the unit-test, I've seen a similar one at plugins/cmake/tests/manual/parentheses_in_test_arguments/, one could do something like that, but I don't really see here arguments passed to the test are checked... (only had a quick look).
| plugins/cmake/cmakeutils.cpp | ||
|---|---|---|
| 694 | Do you want importTestSuites(buildDir, QStringLiteral("CTestTestfile.cmake")) also exported in the .h file? | |