This patch ports global menu's configuration window to QQC2 and Kirigami.FormLayout. It also changed the category icon to be consistent with other applets.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10586: Modernize widget configuration settings
- Commits
- R120:08feca1f6859: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout
Before:
After:
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| applets/appmenu/package/contents/ui/configGeneral.qml | ||
|---|---|---|
| 22 | Probably not but I'm always checking Qt documentation and simply using the import they recommend. Because 5.16 will depend on Qt 5.12 it shouldn't be a problem, but I can leave things as they are. | |
| 27–28 | I'm seeing this consistently, properties don't work at all if placed in Kirigami.FormLayout. In this case if put there you can click on the options but the Apply button will just stay shaded. | |
Comment Actions
Okay so I checked additionally and the top level Item doesn't seem necessary. I guess I copied that style by looking at the systemtray and folderview icon configuration window code, which has an Item as a top level element. Plasma is there any reason for using it or is it fine to just start off with Kirigami.FormLayout instantly?