Differential D19669

[binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout
ClosedPublic
Actions

Authored by filipf on Mar 11 2019, 12:27 AM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R114:7437b39cf8d0: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout
Summary

This patch ports binary-clock's configuration window to QQC2 and Kirigami.FormLayout.

Test Plan

Before:

After:

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Mar 11 2019, 12:27 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 11 2019, 12:27 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 11 2019, 12:27 AM
filipf edited the summary of this revision. (Show Details)Mar 11 2019, 12:28 AM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: VDG, Plasma.

Alternative looks:

ngraham added a subscriber: ngraham.Mar 11 2019, 2:54 AM
In D19669#428757, @filipf wrote:

I vote for this one, or else for putting the color wells below their text and slightly indented.

filipf updated this revision to Diff 53760.Mar 12 2019, 10:20 PM

color pickers in the same row as their option; drop top-level Item

filipf edited the test plan for this revision. (Show Details)Mar 12 2019, 10:21 PM
ngraham requested changes to this revision.Mar 13 2019, 3:09 PM
ngraham added inline comments.
applets/binary-clock/package/contents/ui/configGeneral.qml
25

Is this actually necessary for anything in the diff? If not, I would recommend against changing it.

31

Anchor left and right to the parent's left and right, or else if we ever decide to make the formlayout not horizontally centered, this layout won't get that change automatically.

This revision now requires changes to proceed.Mar 13 2019, 3:09 PM
filipf updated this revision to Diff 53821.Mar 13 2019, 7:04 PM

fix anchors & imports

filipf marked 2 inline comments as done.Mar 13 2019, 7:04 PM
ngraham accepted this revision.Mar 13 2019, 9:02 PM

LGTM!

This revision is now accepted and ready to land.Mar 13 2019, 9:02 PM
Closed by commit R114:7437b39cf8d0: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). · Explain WhyMar 13 2019, 10:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 53842

View Options

applets/binary-clock/package/contents/ui/configGeneral.qml

Loading...