This patch ports binary-clock's configuration window to QQC2 and Kirigami.FormLayout.
Details
Details
- Reviewers
ngraham - Group Reviewers
VDG Plasma - Maniphest Tasks
- T10586: Modernize widget configuration settings
- Commits
- R114:7437b39cf8d0: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout
Before:
After:
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9461 Build 9479: arc lint + arc unit
Comment Actions
I vote for this one, or else for putting the color wells below their text and slightly indented.
applets/binary-clock/package/contents/ui/configGeneral.qml | ||
---|---|---|
23–24 | Is this actually necessary for anything in the diff? If not, I would recommend against changing it. | |
29 | Anchor left and right to the parent's left and right, or else if we ever decide to make the formlayout not horizontally centered, this layout won't get that change automatically. |