[quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
ClosedPublic

Authored by filipf on Mar 10 2019, 10:42 PM.

Details

Summary

This patch ports quickshare's configuration window to QQC2 and Kirigami.FormLayout, as well as matches the General category's icon with the applet's icon.

Test Plan

Before:

After:

Diff Detail

Repository
R114 Plasma Addons
Branch
modernize-quickshare-config (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9543
Build 9561: arc lint + arc unit
filipf created this revision.Mar 10 2019, 10:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 10 2019, 10:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 10 2019, 10:42 PM
filipf edited the summary of this revision. (Show Details)Mar 10 2019, 10:44 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: VDG, Plasma.
apol accepted this revision.Mar 11 2019, 12:15 AM
apol added a subscriber: apol.

Awesome thanks!

This revision is now accepted and ready to land.Mar 11 2019, 12:15 AM
ngraham accepted this revision.Mar 11 2019, 2:54 AM
filipf updated this revision to Diff 53824.Mar 13 2019, 7:09 PM

be conservative with imports and don't use a top level Item

abetts added a subscriber: abetts.Mar 13 2019, 7:19 PM

While it makes sense to change it to the new form, the alignment feels odd because there are just a couple of items in the kcm. I wonder if having a title label would help ground the elements on the page.

ngraham accepted this revision.Mar 13 2019, 8:32 PM

I think it looks fine, actually. Visually, the only change is centering the controls rather than left-aligning them. And the page already has a title.

^ Also I may have may the window wider in the pic than it would be normally

This revision was automatically updated to reflect the committed changes.