This patch ports quickshare's configuration window to QQC2 and Kirigami.FormLayout, as well as matches the General category's icon with the applet's icon.
Details
Details
- Reviewers
apol ngraham - Group Reviewers
VDG Plasma - Maniphest Tasks
- T10586: Modernize widget configuration settings
- Commits
- R114:1a171706e7b3: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout
Before:
After:
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- modernize-quickshare-config (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9456 Build 9474: arc lint + arc unit
Comment Actions
While it makes sense to change it to the new form, the alignment feels odd because there are just a couple of items in the kcm. I wonder if having a title label would help ground the elements on the page.
Comment Actions
I think it looks fine, actually. Visually, the only change is centering the controls rather than left-aligning them. And the page already has a title.