Make global view properties the default setting
ClosedPublic

Authored by elvisangelaccio on Mar 10 2019, 9:53 PM.

Details

Summary

Automatic creation of .directory files is one of the most
complained about things in dolphin.

These days applications are supposed to store application-specific data
within $XDG_DATA_HOME. Long-term that's the proper solution for this
issue, but for now we can at least flip the default so that we no longer
create .directory files out of the box.

A tooltip is also added as a kind of warning for the users who want to
change the setting. Ideally a proper warning should be shown using a
KMessageWidget or KMessageBox, but neither play too well with the
setting dialog workflow used by dolphin.

CCBUG: 322922

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 10 2019, 9:53 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Mar 10 2019, 9:53 PM
ngraham accepted this revision.Mar 11 2019, 12:59 AM
ngraham added a subscriber: ngraham.

I'm very much in favor of this. In addition to working around the issue with the yucky .directory files,I've long believed that this would make a better default setting in general.

This revision is now accepted and ready to land.Mar 11 2019, 12:59 AM
This revision was automatically updated to reflect the committed changes.

BTW, I'm not sure how it could possibly be related, but the placesitemmodel test has started consistently failing after this commit went in: https://build.kde.org/job/Applications/job/dolphin/job/stable-kf5-qt5%20SUSEQt5.10/30/testReport/junit/projectroot.src/tests/placesitemmodeltest/

BTW, I'm not sure how it could possibly be related, but the placesitemmodel test has started consistently failing after this commit went in: https://build.kde.org/job/Applications/job/dolphin/job/stable-kf5-qt5%20SUSEQt5.10/30/testReport/junit/projectroot.src/tests/placesitemmodeltest/

Sorry about that. Fixed with bff373d598c031cb19bac222f90527d4c4c3d567