Differential D19647

[sddm-theme/lock screen] Use QQC2 for the clock labels
ClosedPublic
Actions

Authored by rooty on Mar 10 2019, 7:24 AM.

Details

Reviewers
filipf
ngraham
hein
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10325: 5.16 Login screen improvements
Commits
R120:d7654042677a: [sddm-theme/lock screen] Use QQC2 for the clock labels
Summary

This patch replaces the PlasmaComponents labels in Clock.qml with QQC2 ones. This resolves the issue of the clock letters/numbers getting clipped.

BUG: 404651
FIXED-IN: 5.16

Test Plan

Before and after

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Mar 10 2019, 7:24 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 10 2019, 7:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Mar 10 2019, 7:24 AM
rooty edited the summary of this revision. (Show Details)Mar 10 2019, 7:25 AM
rooty edited the test plan for this revision. (Show Details)
rooty added reviewers: Plasma, VDG, filipf, ngraham.
rooty added a task: T10325: 5.16 Login screen improvements.
rooty retitled this revision from [sddm-theme/lock screen] Use QQC2 instead of PlasmaComponents to [sddm-theme/lock screen] Use QQC2 instead of PlasmaComponents in the clock.Mar 10 2019, 7:32 AM
rooty edited the summary of this revision. (Show Details)
rooty retitled this revision from [sddm-theme/lock screen] Use QQC2 instead of PlasmaComponents in the clock to [sddm-theme/lock screen] Use QQC2 for the clock labels.Mar 10 2019, 7:34 AM
rooty edited the summary of this revision. (Show Details)
filipf added a comment.Mar 10 2019, 8:38 AM

I'd like to first see if we can fix Components, but if not this is probably a better fix than using QtRendering.

ngraham accepted this revision.Mar 10 2019, 3:58 PM
ngraham added subscribers: davidedmundson, mart.

Conceptually and practically, this makes sense. However before we land this, I'd like to get confirmation that this is okay from @mart, @davidedmundson, or another Plasma person familiar with this code.

Also, damn this is looking good.

This revision is now accepted and ready to land.Mar 10 2019, 3:58 PM
rooty added a comment.Mar 11 2019, 2:55 AM

Sure thing

hein accepted this revision.Mar 16 2019, 5:55 PM
Closed by commit R120:d7654042677a: [sddm-theme/lock screen] Use QQC2 for the clock labels (authored by rooty). · Explain WhyMar 16 2019, 6:01 PM
This revision was automatically updated to reflect the committed changes.
rooty edited the summary of this revision. (Show Details)Mar 16 2019, 6:13 PM
rooty edited the summary of this revision. (Show Details)Mar 16 2019, 6:18 PM

Revision Contents
Changeset List

Diff 54030

View Options

lookandfeel/contents/components/Clock.qml

Loading...