Differential D19645

Deprecating rotation function
ClosedPublic
Actions

Authored by karinapassos on Mar 9 2019, 8:58 PM.

Details

Reviewers
tcanabrava
apol
Group Reviewers
KDE Edu
Commits
R323:1af7c48a2df4: Deprecating rotation function
Summary

It wasn't working as planned, so it is deprecated.

Diff Detail

Repository
R323 Analitza
Branch
rotation
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9397
Build 9415: arc lint + arc unit
karinapassos created this revision.Mar 9 2019, 8:58 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 9 2019, 8:58 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
karinapassos requested review of this revision.Mar 9 2019, 8:58 PM
karinapassos retitled this revision from Deprecating rotation function It wasn't working as planned, so it is deprecated. to Deprecating rotation function.Mar 9 2019, 8:59 PM
karinapassos edited the summary of this revision. (Show Details)
karinapassos added reviewers: tcanabrava, apol, KDE Edu.
apol added a comment.Mar 11 2019, 12:02 AM

That's not how we deprecate in C++.

You'll want to use ANALITZAPLOT_DEPRECATED_EXPORT on the method declaration.

tcanabrava added a comment.Mar 11 2019, 10:40 AM
In D19645#428711, @apol wrote:

That's not how we deprecate in C++.

You'll want to use ANALITZAPLOT_DEPRECATED_EXPORT on the method declaration.

Well, it kinda is (as it's a new way to deprecate methods in C++ since C++14)
https://en.cppreference.com/w/cpp/language/attributes/deprecated

The actual error is that she added this to the cpp instead of the header. Also, grepping for DEPRECATED on kalgebra / analitza only showted ANALITZAWIDGETS_DEPRECATED_EXPORT, but no define. is this generated by CMake ?

karinapassos updated this revision to Diff 53871.Mar 14 2019, 10:44 AM
karinapassos edited the summary of this revision. (Show Details)
  • Function deprecated in another way
tcanabrava accepted this revision.Mar 14 2019, 10:49 AM
This revision is now accepted and ready to land.Mar 14 2019, 10:49 AM
apol accepted this revision.Mar 14 2019, 1:09 PM
Closed by commit R323:1af7c48a2df4: Deprecating rotation function (authored by karinapassos, committed by tcanabrava). · Explain WhyApr 23 2019, 11:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Manalitzaplot/plotter3d_es.cpp (1 line)

Diff 53543

View Options

analitzaplot/plotter3d_es.cpp

Loading...