Deprecating rotation function
ClosedPublic

Authored by karinapassos on Mar 9 2019, 8:58 PM.

Details

Summary

It wasn't working as planned, so it is deprecated.

Diff Detail

Repository
R323 Analitza
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
karinapassos created this revision.Mar 9 2019, 8:58 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 9 2019, 8:58 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
karinapassos requested review of this revision.Mar 9 2019, 8:58 PM
karinapassos retitled this revision from Deprecating rotation function It wasn't working as planned, so it is deprecated. to Deprecating rotation function.Mar 9 2019, 8:59 PM
karinapassos edited the summary of this revision. (Show Details)
karinapassos added reviewers: tcanabrava, apol, KDE Edu.
apol added a comment.Mar 11 2019, 12:02 AM

That's not how we deprecate in C++.

You'll want to use ANALITZAPLOT_DEPRECATED_EXPORT on the method declaration.

In D19645#428711, @apol wrote:

That's not how we deprecate in C++.

You'll want to use ANALITZAPLOT_DEPRECATED_EXPORT on the method declaration.

Well, it kinda is (as it's a new way to deprecate methods in C++ since C++14)
https://en.cppreference.com/w/cpp/language/attributes/deprecated

The actual error is that she added this to the cpp instead of the header. Also, grepping for DEPRECATED on kalgebra / analitza only showted ANALITZAWIDGETS_DEPRECATED_EXPORT, but no define. is this generated by CMake ?

karinapassos edited the summary of this revision. (Show Details)
  • Function deprecated in another way
tcanabrava accepted this revision.Mar 14 2019, 10:49 AM
This revision is now accepted and ready to land.Mar 14 2019, 10:49 AM
apol accepted this revision.Mar 14 2019, 1:09 PM
This revision was automatically updated to reflect the committed changes.