Fix to Modulo Shift Continuous
ClosedPublic

Authored by Reptorian on Mar 9 2019, 5:24 PM.

Details

Reviewers
None
Group Reviewers
Krita
Commits
R37:062813134de4: Fix to Modulo Shift Continuous
Summary

Before, I have made several test where white layer wouldn't change anything for all modulo mode to verify that they all work as expected. Then over time, I realized that at this point, modulo shift continuous just doesn't make sense from the functional point of view and the former test just don't take into account of that.

The problem with older version: If you set 0 on the blend layer using modulo shift continuous, it assume that there's a shift because of inversion. However, 0 shift is 0 shift as in there shouldn't be any changes at all.

This patch fix that issue from the functional point of view.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Reptorian created this revision.Mar 9 2019, 5:24 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptMar 9 2019, 5:24 PM
Restricted Application added a project: Krita. · View Herald Transcript
Reptorian requested review of this revision.Mar 9 2019, 5:24 PM
Reptorian edited the summary of this revision. (Show Details)Mar 9 2019, 5:28 PM
Reptorian edited the summary of this revision. (Show Details)Mar 9 2019, 8:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2019, 10:11 PM
Closed by commit R37:062813134de4: Fix to Modulo Shift Continuous (authored by Reptorian, committed by dkazakov). · Explain Why
This revision was automatically updated to reflect the committed changes.