Differential D19636

Fix memory leak of HotSpot
ClosedPublic
Actions

Authored by hallas on Mar 9 2019, 4:44 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:7265be97a2e9: Fix memory leak of HotSpot
Summary

Fixes memory leaf of HotSpots. This is caused by the Filter::reset()
function failing to delete the allocated HotSpots before clearing the
list.

Test Plan

Compile konsole with address sanitizer
Select a link in the terminal
Close konsole

Diff Detail

Repository
R319 Konsole
Branch
fix_memory_leak_of_hot_spots (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9386
Build 9404: arc lint + arc unit
hallas created this revision.Mar 9 2019, 4:44 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 9 2019, 4:44 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
hallas requested review of this revision.Mar 9 2019, 4:44 PM
hindenburg accepted this revision.Mar 13 2019, 2:44 PM
hindenburg added a subscriber: hindenburg.

Thanks

This revision is now accepted and ready to land.Mar 13 2019, 2:44 PM
Closed by commit R319:7265be97a2e9: Fix memory leak of HotSpot (authored by hallas, committed by hindenburg). · Explain WhyMar 13 2019, 2:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/Filter.cpp (9 lines)

Diff 53529

View Options

src/Filter.cpp

Loading...