Fixes a few minor memory leaks found with address sanitizer.
The newTabButton and closeTabButton was not passed a parent and is not
deleted in the destructor of TabbedViewContainer which will cause them
to be leaked when closing a tab. Instead pass the TabbedViewContainer as
the parent.
The same goes for the profileMenu, it was not passed a parent pointer at
contruction and the setMenu function doesn't take ownership of it, so
therefore it was also leaked.
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:03a78c2a9f42: Fixes minor memory leaks
Compile konsole with address sanitizer.
Open and close konsole.
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks, an entire new tab/session code is getting committed to master once the 19.04 split is done next week. I'll wait until than to check your patches.
Comment Actions
Rebased the commit and fixed a few other minor leaks introduced by the new split view code.