Remove find label and use a placeholder text instead
AbandonedPublic

Authored by ognarb on Mar 8 2019, 9:46 PM.

Details

Summary

Old:


New:

Test Plan

Build and run

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9359
Build 9377: arc lint + arc unit
ognarb created this revision.Mar 8 2019, 9:46 PM
Restricted Application added a project: Okular. · View Herald TranscriptMar 8 2019, 9:46 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
ognarb requested review of this revision.Mar 8 2019, 9:46 PM
ognarb edited the summary of this revision. (Show Details)Mar 8 2019, 9:49 PM
ognarb edited the test plan for this revision. (Show Details)
ognarb added reviewers: Okular, VDG.
ognarb edited the summary of this revision. (Show Details)

+1 for removing the label, but in this one case, we actually do want to use "Find..." as the placeholder text since this bar is activated by using the EditFind menu item.

ognarb updated this revision to Diff 53485.Mar 8 2019, 10:23 PM

Use find instead of search

ognarb retitled this revision from Remove find label and use instead the placeholder text 'Search...' to Remove find label and use a placeholder text instead.Mar 8 2019, 10:23 PM
aacid added a subscriber: aacid.Mar 10 2019, 10:24 AM

-1

There's enough horizontal space, once you type the placeholder goes away, then i alt+tab to something else, spend 3 minutes there and come back and my not very smart brain doens't know what's in there

Also since you remove the label you lose the possibility of Alt+Shortcut to focus into it.

All pain and no gain.

ognarb abandoned this revision.Jun 4 2019, 11:56 AM