Differential D19623

Replace all usages QOverload with static_cast
AbandonedPublic
Actions

Authored by abika on Mar 8 2019, 7:18 PM.

Details

Reviewers

None

Group Reviewers

Krusader

Summary

QOverload is only available in Qt >= 5.7.

See https://bugs.kde.org/show_bug.cgi?id=405212 .

Test Plan

Krusader compiles.

Diff Detail

Repository

R167 Krusader

Branch

my-replace-qoverload

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9349
Build 9367: arc lint + arc unit

abika requested review of this revision.Mar 8 2019, 7:18 PM

abika created this revision.

Harbormaster completed remote builds in B9349: Diff 53473.Mar 8 2019, 7:18 PM

What is the purpose of this change?

/krusader/Panel/panelfunc.cpp:520 contains

file.open(QIODevice::NewOnly);

and NewOnly is available since Qt 5.11. So the current git/master only compiles for Qt >= 5.11.

https://doc.qt.io/qt-5/qiodevice.html

Thanks in advance for your answer.

Good point, Yuri. We should look into other cases as well.

IMO, QOverload looks cleaner. Why don't we raise minimal requirements to qt-5.7 or even qt-5.9 LTS, since <= qt-5.6 support will expire in a few days, and work around cases that don't compile with minimal version?

nmel mentioned this in D20099: Compilation fixed with Qt < 5.11.Mar 29 2019, 7:25 AM

nmel mentioned this in D20373: Updated minimal Qt version to the earliest supported version (5.9).Apr 8 2019, 7:59 AM

Discarded in favour of D20373.

Revision Contents
Changeset List

			Path	Packages
M			krusader/Dialogs/krmaskchoice.cpp (3 lines)
M			krusader/Dialogs/newftpgui.cpp (6 lines)
M			krusader/Dialogs/packguibase.cpp (6 lines)
M			krusader/DiskUsage/radialMap/widget.cpp (2 lines)
M			krusader/Filter/generalfilter.cpp (9 lines)
M			krusader/GUI/kcmdline.cpp (4 lines)
M			krusader/Konfigurator/kgcolors.cpp (3 lines)
M			krusader/Konfigurator/konfiguratoritems.cpp (24 lines)
M			krusader/Konfigurator/krresulttable.cpp (5 lines)
M			krusader/Locate/locate.cpp (12 lines)
M			krusader/MountMan/kmountmangui.cpp (6 lines)
M			krusader/Panel/PanelView/krinterbriefview.cpp (3 lines)
M			krusader/Panel/krsearchbar.cpp (3 lines)
M			krusader/Panel/listpanel.cpp (8 lines)
M			krusader/Panel/listpanelactions.cpp (5 lines)
M			krusader/Panel/sidebar.cpp (3 lines)
M			krusader/Splitter/splittergui.cpp (6 lines)
M			krusader/UserAction/kraction.cpp (3 lines)
M			krusader/krslots.h (3 lines)
M			krusader/krusader.cpp (2 lines)
M			krusader/panelmanager.cpp (6 lines)